Skip to content

add module #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 1, 2025
Merged

add module #1336

merged 7 commits into from
Apr 1, 2025

Conversation

frank-msodsp
Copy link
Contributor

Added new module

@frank-msodsp frank-msodsp requested a review from a team as a code owner March 14, 2025 12:17
@frank-msodsp frank-msodsp requested a review from ThomsonTan March 14, 2025 12:24
lalitb
lalitb reviewed Mar 20, 2025
View reviewed changes
Copy link
Contributor

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit comment.
I think the modules repo PR doesn't need to be merged before that.

lalitb
lalitb previously approved these changes Mar 20, 2025
View reviewed changes
@lalitb
Copy link
Contributor

lalitb commented Apr 1, 2025

force merging the PR - the failing CI is not related to the PR.

@lalitb lalitb merged commit 8240060 into main Apr 1, 2025
28 checks passed
@lalitb lalitb deleted the frank-msodsp/sanitizermodule branch April 1, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frank-msodsp @lalitb @ThomsonTan